1
90%
main: 90%

Ran 20 Nov 2025 05:37PM UTC

Files 60

Run time 1s

Badge

Embed ▾

Committed 20 Nov 2025 05:25PM UTC coverage: 88.437% (-3.6%) from 92.046%

Job # 2b03d55c-d9bf-4723-a9fa-30ef2bf41be8.1

Build Type

Pull #2979

circleci

Committed by

sandbergja

Commit Message

Add frozen_string_literals comments to marc_to_solr files that are compatible with them

We don't have the relevant rubocop check enabled, so many files are missing
this magic comment.

This does make MarcBreaker slightly faster, although indexing a full file
takes about the same amount of time.  I checked MarcBreaker's performance
with the following microbenchmark in `rails c`:

```
record = MARC::XMLReader.new(Rails.root.join('spec/fixtures/marc_to_solr/9914141453506421.mrx').to_s).first
Benchmark.ips { it.report { MarcBreaker.break(record) } }
```

Before:
```
Warming up --------------------------------------
                       472.000 i/100ms
Calculating -------------------------------------
                          4.705k (± 1.2%) i/s  (212.53 μs/i) -     23.600k in   5.016528s
```

After:
```
Warming up --------------------------------------
                       512.000 i/100ms
Calculating -------------------------------------
                          5.178k (± 1.4%) i/s  (193.11 μs/i) -     26.112k in   5.043372s
```

Pull Request Pull Request #2979: Add frozen_string_literals comments to marc_to_solr files that are compatible with them

Run Details

5767 of 6521 relevant lines covered (88.44%)

20.47 hits per line

pulibrary / bibdata / 2b03d55c-d9bf-4723-a9fa-30ef2bf41be8 / 1
90%
main: 90%

README BADGES
x

Markdown

Textile

RDoc

HTML

Rst

Source Files on job 2b03d55c-d9bf-4723-a9fa-30ef2bf41be8.1

pulibrary / bibdata / 2b03d55c-d9bf-4723-a9fa-30ef2bf41be8 / 1 90% main: 90%

README BADGES x

Markdown

Textile

RDoc

HTML

Rst

Source Files on job 2b03d55c-d9bf-4723-a9fa-30ef2bf41be8.1

pulibrary / bibdata / 2b03d55c-d9bf-4723-a9fa-30ef2bf41be8 / 1
90%
main: 90%

README BADGES
x