pulibrary / bibdata / 2b03d55c-d9bf-4723-a9fa-30ef2bf41be8

90%

main: 90%

Build Type

Pull #2979

circleci

Committed by sandbergja

Commit Message

Add frozen_string_literals comments to marc_to_solr files that are compatible with them

We don't have the relevant rubocop check enabled, so many files are missing
this magic comment.

This does make MarcBreaker slightly faster, although indexing a full file
takes about the same amount of time.  I checked MarcBreaker's performance
with the following microbenchmark in `rails c`:

```
record = MARC::XMLReader.new(Rails.root.join('spec/fixtures/marc_to_solr/9914141453506421.mrx').to_s).first
Benchmark.ips { it.report { MarcBreaker.break(record) } }
```

Before:
```
Warming up --------------------------------------
                       472.000 i/100ms
Calculating -------------------------------------
                          4.705k (± 1.2%) i/s  (212.53 μs/i) -     23.600k in   5.016528s
```

After:
```
Warming up --------------------------------------
                       512.000 i/100ms
Calculating -------------------------------------
                          5.178k (± 1.4%) i/s  (193.11 μs/i) -     26.112k in   5.043372s
```

Pull Request Pull Request #2979: Add frozen_string_literals comments to marc_to_solr files that are compatible with them

Run Details

2 of 2 new or added lines in 1 file covered. (100.0%)

8 existing lines in 3 files now uncovered.

9022 of 10057 relevant lines covered (89.71%)

327.8 hits per line