1
95%
main: 95%

Ran 02 Oct 2025 10:11AM UTC

Files 45

Run time 1s

Badge

Embed ▾

Committed 02 Oct 2025 09:45AM UTC coverage: 95.033% (-0.001%) from 95.034%

Job # 18189957386.1

Build Type

push

Committed by

albertito

Commit Message

smtpsrv: Fix "Received" header format when including the IP address

When constructing the "Received" header, in some cases we want to
include the remote IP address in addition to the EHLO domain.

The way we did that is not fully compliant with RFC 5321 (section 4.4),
and this has the potential to confuse some tools that parse the header.

This patch fixes this problem by adjusting the order of the two pieces
of data, which makes it comply with the RFC.

Before:

  Received: from [1.2.3.4] (ehlo.domain.example.com)

After:

  Received: from ehlo.domain.example.com ([1.2.3.4])

Thanks to nolanl@github for reporting this problem in
https://github.com/albertito/chasquid/issues/76.

Run Details

5912 of 6221 relevant lines covered (95.03%)

63867.95 hits per line

albertito / chasquid / 18189957386 / 1
95%
main: 95%

README BADGES
x

Markdown

Textile

RDoc

HTML

Rst

Source Files on job 18189957386.1

albertito / chasquid / 18189957386 / 1 95% main: 95%

README BADGES x

Markdown

Textile

RDoc

HTML

Rst

Source Files on job 18189957386.1

albertito / chasquid / 18189957386 / 1
95%
main: 95%

README BADGES
x