albertito / chasquid / 18189957386

95%

main: 95%

push

smtpsrv: Fix "Received" header format when including the IP address

When constructing the "Received" header, in some cases we want to
include the remote IP address in addition to the EHLO domain.

The way we did that is not fully compliant with RFC 5321 (section 4.4),
and this has the potential to confuse some tools that parse the header.

This patch fixes this problem by adjusting the order of the two pieces
of data, which makes it comply with the RFC.

Before:

  Received: from [1.2.3.4] (ehlo.domain.example.com)

After:

  Received: from ehlo.domain.example.com ([1.2.3.4])

Thanks to nolanl@github for reporting this problem in
https://github.com/albertito/chasquid/issues/76.

4 of 4 new or added lines in 1 file covered. (100.0%)

5912 of 6221 relevant lines covered (95.03%)

63867.95 hits per line