1
66%
main: 66%

Ran 23 Sep 2025 08:22PM UTC

Files 32

Run time 1s

Badge

Embed ▾

Committed 23 Sep 2025 07:56PM UTC coverage: 66.455% (+0.2%) from 66.288%

Job # 17957503606.1

Build Type

push

github

Committed by

web-flow

Commit Message

Check the results of `has_side_effect` for binary expressions. (#497)

Currently, if the output of `UniformRand` is used in multiple dependent
expressions, a new random number will be generated every time. This is
at odds with the behavior of `BuiltInOperator::Rand`. The code *tries*
to account for this by implementing `has_side_effect()` on binary
expressions, but this is never actually checked. That's because
`has_side_effect()` is only examined for *built-in* expressions, which
`UniformRand` is not one of.

This commit factors the logic to create a local variable if there are no
side effects out of `BuiltInExpr` into a separate function and calls
that function in `Expr::Binary` and `BuiltInExpr`, fixing the issue.

A separate issue is that `Expr::has_side_effect()` is perhaps too
aggressive, in that binary operators check to see whether their LHS and
RHS are side-effecting and mark themselves as side-effecting if they
are, when in fact only the operator itself determines whether the
expression is side-effecting for the purposes of generating new
temporaries. This causes many expressions to be marked as side-effecting
that actually aren't. I opted not to fix this issue in this PR to keep
this PR small, as it only results in more temporaries being generated,
which shader compilers will clean up.

Run Details

4917 of 7399 relevant lines covered (66.45%)

449.07 hits per line

djeedai / bevy_hanabi / 17957503606 / 1
66%
main: 66%

README BADGES
x

Markdown

Textile

RDoc

HTML

Rst

Source Files on job 17957503606.1

djeedai / bevy_hanabi / 17957503606 / 1 66% main: 66%

README BADGES x

Markdown

Textile

RDoc

HTML

Rst

Source Files on job 17957503606.1

djeedai / bevy_hanabi / 17957503606 / 1
66%
main: 66%

README BADGES
x