1
87%
master: 94%

Ran 11 Aug 2016 12:35PM UTC

Files 54

Run time 3s

Badge

Embed ▾

Committed 11 Aug 2016 12:28PM UTC coverage: 87.109%. Remained the same

Job # auth_token=[secure]

Build Type

push

travis-ci

Committed by

quis

Commit Message

Make service API client do partial updates

The service API client was updating every attribute of a service. Which,
while kinda clunky, is fine…

…until something calling it doesn’t pass in every attribute of the
current service. It was then defaulting optional parameters to `None`.
Which resulted in a bug whereby every time a service was set to live,
its `reply_to_address` and `sms_sender_name` got overwritten to be
empty.

This commit changes the `update` method to only require the service ID,
and pass whatever other named arguments it received straight through to
the API. The API handles partial updates just fine (I think).

Coverage Stats

2007 of 2304 relevant lines covered (87.11%)

0.87 hits per line

alphagov / notifications-admin / 4223 / 1
87%
master: 94%

README BADGES
x

Markdown

Textile

RDoc

HTML

Rst

Source Files on job 4223.1 (auth_token=[secure])

alphagov / notifications-admin / 4223 / 1 87% master: 94%

README BADGES x

Markdown

Textile

RDoc

HTML

Rst

Source Files on job 4223.1 (auth_token=[secure])

alphagov / notifications-admin / 4223 / 1
87%
master: 94%

README BADGES
x