alphagov / notifications-admin / 4223

87%

master: 94%

push

travis-ci

Make service API client do partial updates

The service API client was updating every attribute of a service. Which,
while kinda clunky, is fine…

…until something calling it doesn’t pass in every attribute of the
current service. It was then defaulting optional parameters to `None`.
Which resulted in a bug whereby every time a service was set to live,
its `reply_to_address` and `sms_sender_name` got overwritten to be
empty.

This commit changes the `update` method to only require the service ID,
and pass whatever other named arguments it received straight through to
the API. The API handles partial updates just fine (I think).

3 of 3 new or added lines in 1 file covered. (100.0%)

2007 of 2304 relevant lines covered (87.11%)

0.87 hits per line