kobotoolbox / kpi / 17134834919 / 2

81%

master: 76%

push

github

fix(attachments): set attachment `is_deleted` flag in Mongo after auto cleanup DEV-922 (#6144)

### 📣 Summary
Ensure that when Celery task automatically deletes excess attachments,
the API correctly marks them as deleted so the UI no longer attempts to
display them.


### 📖 Description
Previously, when attachments were automatically removed because a user
exceeded their storage quota, the cleanup process only updated Postgres.
The corresponding Mongo documents were not updated, leaving the
`is_deleted` flag set to `False`.

This caused the API to continue reporting attachments as active, leading
the UI to try to fetch and display files that had already been deleted.

With this fix, the `auto_delete_excess_attachments` task also updates
Mongo using `ParsedInstance.bulk_update_attachments`, ensuring that
`is_deleted` is set to `True`. As a result, the API and UI now
immediately reflect the correct state after cleanup.

6502 of 10194 branches covered (63.78%)

24462 of 30045 relevant lines covered (81.42%)

0.81 hits per line