5
61%
master: 63%

Ran 11 Aug 2025 01:36PM UTC

Files 88

Run time 3s

Badge

Embed ▾

Committed 11 Aug 2025 01:05PM UTC coverage: 60.691% (-0.2%) from 60.845%

Job # 5241029613322240.5

Build Type

Pull #10120

CirrusCI

Committed by

f321x

Commit Message

fix: wizard: qml: call checkIfLast in WCHaveSeed

When the user has already loaded a wallet in QML and tries to restore a
new wallet `WCHaveSeed.qml` incorrectly shows a `Finish` button instead
of a `Next` button and raises a KeyError if the user clicks on Finish
instead of resolving the passphrase input view (regression from
https://github.com/spesmilo/electrum/pull/10016).

This happens because `last` of `have_seed` depends on
`NewWalletWizard.is_single_password()` and NewWalletWizard.wants_ext(wizard_data).
`is_single_password()` is true if a wallet is already loaded,
while `wants_ext(wizard_data)` is false as `wants_ext()` depends on `seed_extend: True` in
`wizard_data` which only gets set after `apply()` of `WCHaveSeed` gets
called, however the evaluation of `WCHaveSeed` being the last view
happens before the view is shown.
By calling `checkIsLast()` in the validation timer of `WCHaveSeed` the
`last` property gets set again after `apply()` has been called, so
the view is guaranteed to correctly show either the `Finish` or `Next` button
after a seed has been entered.

Pull Request Pull Request #10120: fix: wizard: qml: call checkIfLast in WCHaveSeed

Run Details

22463 of 37012 relevant lines covered (60.69%)

0.61 hits per line

spesmilo / electrum / 5241029613322240 / 5
61%
master: 63%

README BADGES
x

Markdown

Textile

RDoc

HTML

Rst

Source Files on job 5241029613322240.5

spesmilo / electrum / 5241029613322240 / 5 61% master: 63%

README BADGES x

Markdown

Textile

RDoc

HTML

Rst

Source Files on job 5241029613322240.5

spesmilo / electrum / 5241029613322240 / 5
61%
master: 63%

README BADGES
x