5241029613322240
61%
master: 64%

Ran 11 Aug 2025 01:12PM UTC

Jobs 5

Files 88

Run time 1min

Badge

Embed ▾

Committed 11 Aug 2025 01:05PM UTC coverage: 60.934% (+0.02%) from 60.91%

Build # 5241029613322240

Build Type

Pull #10120

CirrusCI

Committed by

f321x

Commit Message

fix: wizard: qml: call checkIfLast in WCHaveSeed

When the user has already loaded a wallet in QML and tries to restore a
new wallet `WCHaveSeed.qml` incorrectly shows a `Finish` button instead
of a `Next` button and raises a KeyError if the user clicks on Finish
instead of resolving the passphrase input view (regression from
https://github.com/spesmilo/electrum/pull/10016).

This happens because `last` of `have_seed` depends on
`NewWalletWizard.is_single_password()` and NewWalletWizard.wants_ext(wizard_data).
`is_single_password()` is true if a wallet is already loaded,
while `wants_ext(wizard_data)` is false as `wants_ext()` depends on `seed_extend: True` in
`wizard_data` which only gets set after `apply()` of `WCHaveSeed` gets
called, however the evaluation of `WCHaveSeed` being the last view
happens before the view is shown.
By calling `checkIsLast()` in the validation timer of `WCHaveSeed` the
`last` property gets set again after `apply()` has been called, so
the view is guaranteed to correctly show either the `Finish` or `Next` button
after a seed has been entered.

Pull Request Pull Request #10120: fix: wizard: qml: call checkIfLast in WCHaveSeed

Run Details

22484 of 36899 relevant lines covered (60.93%)

3.04 hits per line

Jobs

ID	Job ID	Ran	Files	Coverage
1	5241029613322240.1	11 Aug 2025 01:12PM UTC	88	60.83
2	5241029613322240.2	11 Aug 2025 01:12PM UTC	88	60.84
3	5241029613322240.3	11 Aug 2025 01:12PM UTC	88	60.82
4	5241029613322240.4	11 Aug 2025 01:26PM UTC	88	60.72
5	5241029613322240.5	11 Aug 2025 01:36PM UTC	88	60.69

spesmilo / electrum / 5241029613322240
61%
master: 64%

README BADGES
x

Markdown

Textile

RDoc

HTML

Rst

Jobs

Source Files on build 5241029613322240

spesmilo / electrum / 5241029613322240 61% master: 64%

README BADGES x

Markdown

Textile

RDoc

HTML

Rst

Jobs

Source Files on build 5241029613322240

spesmilo / electrum / 5241029613322240
61%
master: 64%

README BADGES
x