kobotoolbox / kpi / 16807153660 / 1

81%

master: 76%

push

github

feat(projectOwnership): log errors in transferring attachments DEV-842 (#6060)

### 💭 Notes
Right now we are swallowing errors when trying to move attachments. The
jobs occasionally fail and the lack of logging makes it difficult to
diagnose, so this logs the error before returning False.

### 👀 Preview steps
Make sure you are using s3 storage

1. ℹ️ have at least 2 accounts and a project with an image question
2. Add a few submissions with attachments to the project
3. Transfer the project to another user
4. Before accepting the transfer, update `kpi.fields.file.py:20-23` with
```
        from django.apps import apps
        Attachment = apps.get_model(model_name='Attachment', app_label='logger')
        if isinstance(self.instance, Attachment):
            name = 'bad name'
        else:
            name = self.name
        copy_source = {
            'Bucket': self.storage.bucket.name,
            'Key': name,
        }
```
Make sure to restart the worker to pick up the changes
5. As the other user, accept the transfer invitation
6. 🔴 [on main] Notice there is only an `AsyncTaskException` in the
worker logs
7. 🟢 [on PR] Notice there is both an `AsyncTaskException` and a more
detailed `ClientError` in the logs

6180 of 9770 branches covered (63.25%)

23356 of 28843 relevant lines covered (80.98%)

0.81 hits per line