agama-project
/
agama
/
15919434531
/
1 – rust
74%
master: 74%
master: 74%
|
Ran
|
Files
172
|
Run time
4s
|
Badge
Embed ▾
README BADGES
|
coverage: 22.001%. First build
push
github
web-flowfix(rust): fix error formatting (#2471) ## Problem The error format is pretty confusing: ``` $ agama --insecure --host 'https:/localhost' auth login > Please enter the root password: ******** Error: error sending request for url (https://https/localhost/api/auth): client error (Connect): dns error: failed to lookup address information: Name or service not known: failed to lookup address information: Name or service not known ``` ## Solution Although far from ideal, introducing a minimal change makes it more readable (kind of): ``` $ agama --insecure --host 'https://localhost' auth login` > Please enter the root password: ******** error sending request for url (https://localhost/api/auth) Caused by: 0: client error (Connect) 1: tcp connect error: Connection refused (os error 111) 2: Connection refused (os error 111) ``` ## Now what? Now we need to invest in improving the error messages. As you can see, the following one looks repetitive: ``` Retrieving data from URL http://192.168.122.1/agama/scripts.jsonnets Caused by: 0: Could not retrieve 'http://192.168.122.1/agama/scripts.jsonnets': [22] HTTP response code said error (The requested URL returned error: 404) 1: [22] HTTP response code said error (The requested URL returned error: 404) ``` Just a [minor change](08271203c) helps to get a better message: ``` Retrieving data from URL http://192.168.122.1/agama/scripts.jsonnets Caused by: 0: Could not retrieve http://192.168.122.1/agama/scripts.jsonnets 1: [22] HTTP response code said error (The requested URL returned error: 404) ``` ## Testing - *Tested manually*
1913 of 8695 relevant lines covered (22.0%)
0.43 hits per line
