kobotoolbox / kpi / 15884288316 / 1

81%

master: 76%

push

github

fix(assets): fix empty xml is returned when XLSForm is invalid DEV-576 (#5855)

### 📣 Summary
Fixes a bug where downloading the XML of an invalid XLSForm returned a
200 response with an empty file. We now returns an error if the form
fails to compile to XML.


### 📖 Description
Previously, if a user uploaded an invalid XLSForm, the system would
allow the asset to be created, and the Download XML link would appear.
However, clicking it would return a 200 response with an empty xml file.

This fix ensures that:
- The invalid XLSForm still results in a saved AssetSnapshot (for
debugging and traceability)
- The API endpoint for downloading the XML (`.xml`) now checks the
compilation status
- If the XML compilation failed (status: 'failure'), an error is
returned with a helpful message

This avoids silent failures and meets the expectation that invalid form
structure should be clearly communicated at the point of failure.

6138 of 9732 branches covered (63.07%)

23176 of 28704 relevant lines covered (80.74%)

0.81 hits per line