rust-bitcoin / rust-bitcoin / 15799905001 / 1

83%

master: 83%

push

github

Merge rust-bitcoin/rust-bitcoin#4630: units: Remove serde derive feature

<a class=hub.com/rust-bitcoin/rust-bitcoin/commit/d8377d90dd8d6bd066f51f45c23ffdfe2d0ab694">d8377d90d<a href="https://github.com/rust-bitcoin/rust-bitcoin/commit/51f78bbb4cd883d4dd767333f6a56c1006b26029"> units: Remove serde derive feature (Tobin C. Harding)
<a class="double-link" href="https://github.com/rust-bitcoin/rust-bitcoin/commit/1031851da408ee038d0a72ac652f7438a88df4ca">1031851da</a> units: Manually implement serde traits for block types (Tobin C. Harding)

Pull request description:

  Currently we only need the `derive` feature of `serde` in test code.
  
  Observe:
  
  - We do not need the error testing logic because `ParseAmountError` is already exhaustively tested.
  - The rest of the `serde` test logic in `amount` can be done using the public API so it can be moved to the integration test directory.
  
  Move the unit test code to `tests/` excluding the error testing logic. Remove the `derive` feature from the `serde` dependency. Add a `dev-dependency` on `serde` that enables the `derive` feature.


ACKs for top commit:
  apoelstra:
    ACK d8377d90dd8d6bd066f51f45c23ffdfe2d0ab694; successfully ran local tests; nice!


Tree-SHA512: 03eb24ae1db6474f60ea8deb4cfddb4ed3f

23500 of 27921 relevant lines covered (84.17%)

15846.27 hits per line