rust-bitcoin / rust-bitcoin / 15799905001
83%

DEFAULT BRANCH: master
Ran
Jobs 1
Files 130
Run time 1min
Badge
Embed ▾
README BADGES
x

If you need to use a raster PNG badge, change the '.svg' to '.png' in the link

Markdown

Textile

RDoc

HTML

Rst
coverage: 84.166% (-0.2%) from 84.32%
15799905001

push

github

apoelstra 
Merge rust-bitcoin/rust-bitcoin#4630: units: Remove serde derive feature

<a class=hub.com/rust-bitcoin/rust-bitcoin/commit/d8377d90dd8d6bd066f51f45c23ffdfe2d0ab694">d8377d90d<a href="https://github.com/rust-bitcoin/rust-bitcoin/commit/51f78bbb4cd883d4dd767333f6a56c1006b26029"> units: Remove serde derive feature (Tobin C. Harding)
<a class="double-link" href="https://github.com/rust-bitcoin/rust-bitcoin/commit/1031851da408ee038d0a72ac652f7438a88df4ca">1031851da</a> units: Manually implement serde traits for block types (Tobin C. Harding)

Pull request description:

  Currently we only need the `derive` feature of `serde` in test code.
  
  Observe:
  
  - We do not need the error testing logic because `ParseAmountError` is already exhaustively tested.
  - The rest of the `serde` test logic in `amount` can be done using the public API so it can be moved to the integration test directory.
  
  Move the unit test code to `tests/` excluding the error testing logic. Remove the `derive` feature from the `serde` dependency. Add a `dev-dependency` on `serde` that enables the `derive` feature.


ACKs for top commit:
  apoelstra:
    ACK d8377d90dd8d6bd066f51f45c23ffdfe2d0ab694; successfully ran local tests; nice!


Tree-SHA512: 03eb24ae1db6474f60ea8deb4cfddb4ed3f

210 of 278 new or added lines in 9 files covered. (75.54%)

173 existing lines in 13 files now uncovered.

23500 of 27921 relevant lines covered (84.17%)

15846.27 hits per line

Uncovered Changes

Lines Coverage ∆ File
41
78.42
 0.0% p2p/src/lib.rs
16
63.64
 0.0% units/src/result.rs
7
86.27
 0.0% p2p/src/consensus.rs
2
67.06
 0.0% p2p/src/message_network.rs
1
92.61
 0.0% p2p/src/message.rs
1
60.0
 0.0% p2p/src/message_bloom.rs

Coverage Regressions

Lines Coverage ∆ File
34
82.13
 -1.98% units/src/block.rs
30
92.61
 0.0% p2p/src/message.rs
26
22.05
 -20.47% units/src/amount/error.rs
21
81.46
 0.0% units/src/locktime/relative.rs
15
63.64
 0.0% units/src/result.rs
14
91.81
 0.0% p2p/src/address.rs
9
85.71
 0.0% primitives/src/sequence.rs
8
90.38
 -3.85% units/src/amount/serde.rs
8
98.94
 0.52% units/src/amount/tests.rs
4
68.18
 0.0% p2p/src/message_blockdata.rs
2
67.06
 0.0% p2p/src/message_network.rs
1
94.74
 0.0% bitcoin/src/lib.rs
1
86.44
 0.29% bitcoin/src/psbt/mod.rs
Jobs
ID Job ID Ran Files Coverage
1 15799905001.1 130
84.17
 GitHub Action Run
Source Files on build 15799905001