1
98%
master: 98%

Ran 19 Jul 2016 11:42PM UTC

Files 137

Run time 6s

Badge

Embed ▾

Committed 19 Jul 2016 11:33PM UTC coverage: 98.302%. Remained the same

Job # 1086.1

Build Type

push

travis-ci

Committed by

web-flow

Commit Message

Add `message` and `locations` as enumerable properties on GraphQLError. (#443)

As brought up in #426, it can be confusing to return instances of `Error` from the `graphql` function since the expectation is that you will call `JSON.stringify` and submit the result to a client. Calling `JSON.stringify` on an instance of `Error` results in `{}` since it has no enumerable properties.

In order to have behavior that matches the GraphQL spec easier to achieve, this makes these two properties enumerable. I think this will be the best of both worlds - anyone who wishes the operate directly on the Error instances will still have the ability to do so (for example, to access the `stack` property), but it can still be converted to JSON directly and get a spec-compliant result.

Run Details

7179 of 7303 relevant lines covered (98.3%)

1370.54 hits per line

graphql / graphql-js / 1086 / 1
98%
master: 98%

README BADGES
x

Markdown

Textile

RDoc

HTML

Rst

Source Files on job 1086.1

graphql / graphql-js / 1086 / 1 98% master: 98%

README BADGES x

Markdown

Textile

RDoc

HTML

Rst

Source Files on job 1086.1

graphql / graphql-js / 1086 / 1
98%
master: 98%

README BADGES
x