graphql / graphql-js / 1086

98%

push

travis-ci

Add `message` and `locations` as enumerable properties on GraphQLError. (#443)

As brought up in #426, it can be confusing to return instances of `Error` from the `graphql` function since the expectation is that you will call `JSON.stringify` and submit the result to a client. Calling `JSON.stringify` on an instance of `Error` results in `{}` since it has no enumerable properties.

In order to have behavior that matches the GraphQL spec easier to achieve, this makes these two properties enumerable. I think this will be the best of both worlds - anyone who wishes the operate directly on the Error instances will still have the ability to do so (for example, to access the `stack` property), but it can still be converted to JSON directly and get a spec-compliant result.

8 of 8 new or added lines in 3 files covered. (100.0%)

7179 of 7303 relevant lines covered (98.3%)

1370.54 hits per line