kobotoolbox / kpi / 14708226741 / 1

81%

master: 76%

push

github

test: add query-counting tests to critical endpoints (#5696)

### 💭 Notes
Add query-counting tests to the following endpoints:

/assets - AssetViewSet (v1), tested in v1/test_api_assets.py
/api/v2/assets/*uid*/data - DataViewSet, tested in test_data_viewset.py
/api/v2/assets - AssetViewSet, tested in v2/test_api_assets.py
/assets/*uid*/submissions - SubmissionViewSet, tested in
v1/test_api_submissions.py
/*username*/submission - XFormSubmissionApi, tested in
test_xform_submission_api.py

Adding these tests revealed that we were in fact hitting the database
once per asset to get export settings, so this PR also adds
export_settings to the prefetched attributes, and replaces the
serializer method field with the built-in django nested serializer.

### Preview Steps
1. Have an account and a project
2. Make sure the project has at least one select-one question
3. Add a few submissions to the project
4. Go to Data -> Downloads
5. Open Advanced Settings and check 'Save selection'
6. Export the data (you won't actually need the exported data)
7. [on main] go to `api/v2/assets` and take note of what is in the
export_settings field of your project
8. [on main] go to `api/v2/assets/<asset_uid>` and similarly take note
of what is in the export_settings field
9. [on branch] go to the same 2 endpoints and make sure the
export_settings are the same

6025 of 9840 branches covered (61.23%)

22879 of 29083 relevant lines covered (78.67%)

0.79 hits per line