1
66%
main: 66%

Ran 20 Apr 2025 12:51AM UTC

Files 29

Run time 1s

Badge

Embed ▾

Committed 20 Apr 2025 12:45AM UTC coverage: 39.388% (-0.04%) from 39.429%

Job # 14554380573.1

Build Type

push

github

Committed by

web-flow

Commit Message

Try reextracting next frame if an effect isn't loaded

Hanabi uses the `Added<CompiledEffect>` query filter in order to
determine when particle effects should be added to the `added_effects`
table. But, if the particle effect asset isn't loaded at the time that
query runs, Hanabi will skip adding the particle effect to that table.
Because the `Added<CompiledEffect>` query filter will only match
particle effects once, once the particle effect asset finally loads,
it's too late to add it to the `added_effects` list. Thus it will never
show up.

This patch fixes the issue by adding effects that are newly added but
not yet fully loaded to a `pending_effects` list. The `added_effects`
loop is modified to not only take into account effects that match the
`Added<CompiledEffect>` filter but also effects in the `pending_effects`
list. Effectively, that means if a particle effect isn't loaded yet, we
poll it on subsequent frames until it finally is loaded before adding it
to `added_effects`. This pattern is the same one used in many places in
the Bevy renderer.

Run Details

3027 of 7685 relevant lines covered (39.39%)

17.43 hits per line

djeedai / bevy_hanabi / 14554380573 / 1
66%
main: 66%

README BADGES
x

Markdown

Textile

RDoc

HTML

Rst

Source Files on job 14554380573.1

djeedai / bevy_hanabi / 14554380573 / 1 66% main: 66%

README BADGES x

Markdown

Textile

RDoc

HTML

Rst

Source Files on job 14554380573.1

djeedai / bevy_hanabi / 14554380573 / 1
66%
main: 66%

README BADGES
x