kobotoolbox / kpi / 14452689498 / 1

81%

master: 76%

push

github

refactor(attachments): expose uid instead of pk in the data API endpoint TASK-1522  (#5642)

### 💭 Notes

Exposes `uid` field in the attachments API response and also removed
`instance`, `xform`, and `id` fields.
The data API response for attachments now looks like this:

```
_attachments": [
        {
            "download_url": "<http://kf.kobo.local/api/v2/assets/amgRCC32PRBWSuxtthtvro/data/23/attachments/attund5vyh8rSr5QM86uPwUj/>",
            "download_large_url": "<http://kf.kobo.local/api/v2/assets/amgRCC32PRBWSuxtthtvro/data/23/attachments/attund5vyh8rSr5QM86uPwUj/large/>",
            "download_medium_url": "<http://kf.kobo.local/api/v2/assets/amgRCC32PRBWSuxtthtvro/data/23/attachments/attund5vyh8rSr5QM86uPwUj/medium/>",
            "download_small_url": "<http://kf.kobo.local/api/v2/assets/amgRCC32PRBWSuxtthtvro/data/23/attachments/attund5vyh8rSr5QM86uPwUj/small/>",
            "mimetype": "image/jpeg",
            "filename": "test/attachments/6c8611aa5ed349cc88da7d32fe4a9933/39e76a6d-380d-424c-b6f9-2d0a15a6985d/IMG_8891-12_10_59.jpg",
            "uid": "attund5vyh8rSr5QM86uPwUj",
            "question_xpath": "Point_and_shoot_Use_camera_to_take_a_photo"
        }
]

```

### 👀 Preview steps

1. ℹ️ have account and a project
2. Make some submissions with attachments
3. Check out the data attachments api:
`https://[kpi]/api/v2/assets/<asset_uid>/data/<data_id>/attachments/<attachment_id>/`
4. Notice that on main the `<attachment_id>` uses the `pk`
5. Checkout this branch
6. 🟢 now notice that the `<attachment_id>` uses the `uid`
7. Make sure that you can still access the attachment using the `pk`
8. Ensure you can make submissions with attachments
9. Ensure you can edit the attachment

6013 of 9792 branches covered (61.41%)

22838 of 28971 relevant lines covered (78.83%)

0.79 hits per line