yarpc / yarpc-go / 1372 / 3

Ran 14 Jul 2016 06:44PM UTC

Files 76

Run time 3s

Badge

Embed ▾

Committed 14 Jul 2016 06:22PM UTC coverage: 93.061% (-0.09%) from 93.152%

Job # 1372.3

Build Type

push

travis-ci

Committed by

web-flow

Commit Message

thrift: Add opaque options for clients and registration (#263)

The client change requires a code generation change, but this will allow
users to do,

    keyvalueclient.New(
        dispatcher.Channel("keyvalue"),
        thrift.DisableEnveloping,
        thrift.ClientOptionA(x),
        thrift.ClientOptionB(y),
    )

Similarly, without any code generation changes, we'll be able to support,

    thrift.Register(
        dispatcher,
        keyvalueserver.New(foo),
        thrift.DisableEnveloping,
        thrift.ServerOptionA(x),
        thrift.ServerOptionB(y),
    )

Note that `DisableEnveloping` has the type `Option` so it can be used for both, client and registration options.

Related thriftrw change: https://github.com/thriftrw/thriftrw-go/pull/167

----

With this change, we'll be able to disable enveloping for HTTP in #256, allowing our existing crossdock tests to pass.

Run Details

3527 of 3790 relevant lines covered (93.06%)

0.98 hits per line

yarpc / yarpc-go / 1372 / 3

README BADGES
x

Markdown

Textile

RDoc

HTML

Rst

Source Files on job 1372.3

yarpc / yarpc-go / 1372 / 3

README BADGES x

Markdown

Textile

RDoc

HTML

Rst

Source Files on job 1372.3

README BADGES
x