1372

Ran 14 Jul 2016 06:44PM UTC

Jobs 4

Files 76

Run time 1min

Badge

Embed ▾

pending completion

Build # 1372

Build Type

push

travis-ci

Committed by

web-flow

Commit Message

thrift: Add opaque options for clients and registration (#263)

The client change requires a code generation change, but this will allow
users to do,

    keyvalueclient.New(
        dispatcher.Channel("keyvalue"),
        thrift.DisableEnveloping,
        thrift.ClientOptionA(x),
        thrift.ClientOptionB(y),
    )

Similarly, without any code generation changes, we'll be able to support,

    thrift.Register(
        dispatcher,
        keyvalueserver.New(foo),
        thrift.DisableEnveloping,
        thrift.ServerOptionA(x),
        thrift.ServerOptionB(y),
    )

Note that `DisableEnveloping` has the type `Option` so it can be used for both, client and registration options.

Related thriftrw change: https://github.com/thriftrw/thriftrw-go/pull/167

----

With this change, we'll be able to disable enveloping for HTTP in #256, allowing our existing crossdock tests to pass.

Run Details

3527 of 3790 relevant lines covered (93.06%)

3.94 hits per line

Jobs

ID	Job ID	Ran	Coverage
1	1372.1	14 Jul 2016 06:45PM UTC	93.06	Travis Job 1372.1
2	1372.2	14 Jul 2016 06:45PM UTC	93.06	Travis Job 1372.2
3	1372.3	14 Jul 2016 06:44PM UTC	93.06	Travis Job 1372.3
4	1372.4	14 Jul 2016 06:46PM UTC	93.06	Travis Job 1372.4

Source Files on build 1372

Detailed source file information is not available for this build.

yarpc / yarpc-go / 1372

README BADGES
x

Markdown

Textile

RDoc

HTML

Rst

Jobs

Source Files on build 1372

yarpc / yarpc-go / 1372

README BADGES x

Markdown

Textile

RDoc

HTML

Rst

Jobs

Source Files on build 1372

README BADGES
x