Warning: This build has drifted.
The coverage report for this pull request build may be inaccurate because its base commit is no longer the HEAD of its target branch.
This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

    • Learn more: For more information on this, see Tracking coverage changes for pull request builds.
    • Fix now: For a quick fix, rebase this PR at GitHub. Your next report should be accurate.
    • Prevent going forward: To avoid this issue with future PRs, see these Recommended CI Configurations.

review: remove ExpiringCommitments struct

The inciting motivation here was to make the full ProjectCommitment
object available to the template, like in
e3daee216.

This required splitting the discover phase into two separate queries,
one for the commitment objects themselves and one for context joined
from other tables. It then appeared natural to me to make the discover
phase very lean and only load commitments there, and do all the
remaining work in the processing phase.