Warning: This build has drifted.
The coverage report for this pull request build may be inaccurate because its base commit is no longer the HEAD of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.
• Learn more: For more information on this, see Tracking coverage changes for pull request builds.
• Fix now: For a quick fix, rebase this PR at GitHub. Your next report should be accurate.
• Prevent going forward: To avoid this issue with future PRs, see these Recommended CI Configurations.
The coverage report for this pull request build may be inaccurate because its base commit is no longer the HEAD of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.
• Learn more: For more information on this, see Tracking coverage changes for pull request builds.
• Fix now: For a quick fix, rebase this PR at GitHub. Your next report should be accurate.
• Prevent going forward: To avoid this issue with future PRs, see these Recommended CI Configurations.
New Repo Setting:
INCLUDE COVERAGE % WITH WARNINGS ABOUT DRIFTED BUILDS?
INCLUDE COVERAGE % WITH WARNINGS ABOUT DRIFTED BUILDS?
Enabling this setting will include a (potentially inaccurate) coverage % with warning messages in status updates for drifted builds.
Adjust setting
sapcc
/
limes
/
13526281332
79%
master: 80%
master: 80%
|
Ran
|
Jobs
1
|
Files
64
|
Run time
1min
|
Badge
Embed ▾
README BADGES
|
coverage: 79.422% (-0.2%) from 79.629%
github
majewskyreview: remove ExpiringCommitments struct The inciting motivation here was to make the full ProjectCommitment object available to the template, like in e3daee216. This required splitting the discover phase into two separate queries, one for the commitment objects themselves and one for context joined from other tables. It then appeared natural to me to make the discover phase very lean and only load commitments there, and do all the remaining work in the processing phase.
188 of 254 new or added lines in 10 files covered. (74.02%)
16 existing lines in 1 file now uncovered.5747 of 7236 relevant lines covered (79.42%)
63.34 hits per line
New Missed Lines in Diff
| Lines | Coverage | ∆ | File |
|---|---|---|---|
| 2 |
80.08 |
-0.4% | internal/collector/capacity_scrape.go |
| 4 |
90.0 |
internal/collector/mail_delivery.go | |
| 4 |
78.31 |
-1.43% | internal/core/cluster.go |
| 10 |
72.97 |
internal/core/mail.go | |
| 10 |
84.31 |
-1.4% | internal/datamodel/confirm_project_commitments.go |
| 18 |
80.0 |
internal/collector/expiring_commitments.go | |
| 18 |
0.0 |
internal/collector/mail_client.go |
Uncovered Existing Lines
| Lines | Coverage | ∆ | File |
|---|---|---|---|
| 16 |
57.78 |
0.0% | internal/core/config.go |
Jobs
| ID | Job ID | Ran | Files | Coverage | |
|---|---|---|---|---|---|
| 1 | 13526281332.1 | 64 |
79.42 |
GitHub Action Run |
