22
60%
master: 60%

Ran 17 Feb 2025 10:55AM UTC

Files 190

Run time 7s

Badge

Embed ▾

Committed 17 Feb 2025 04:05AM UTC coverage: 64.631%. Remained the same

Job # 13362634257.22

Build Type

push

github

Committed by

ChrisThrasher

Commit Message

Fix comments and address ordering in IpAddress::getLocalAddress

The old code says "The method here is to connect a UDP socket to
anyone (here to localhost)", but connecting to `localhost` doesn't
work because the connection would go via the loopback interface which
always has a local address of `127.0.0.1`.

The current code works on little-endian platforms due to a mistake in
the `createAddress` call. We pass `ntohl(INADDR_LOOPBACK)` as the IP,
but since `INADDR_LOOPBACK` is already in host order this actually
connects to `1.0.0.127`.

Fix the comments and intentionally connect to `1.1.1.1` (as a known
public IP address). This also fixes this call for big-endian
platforms.

Run Details

6891 of 10662 relevant lines covered (64.63%)

0.65 hits per line

SFML / SFML / 13362634257 / 22
60%
master: 60%

README BADGES
x

Markdown

Textile

RDoc

HTML

Rst

Source Files on job Windows VS2022 ClangCL MSBuild Static Debug - 13362634257.22

SFML / SFML / 13362634257 / 22 60% master: 60%

README BADGES x

Markdown

Textile

RDoc

HTML

Rst

Source Files on job Windows VS2022 ClangCL MSBuild Static Debug - 13362634257.22

SFML / SFML / 13362634257 / 22
60%
master: 60%

README BADGES
x