SFML / SFML / 13362634257

60%

Build Type

push

github

Committed by ChrisThrasher

Commit Message

Fix comments and address ordering in IpAddress::getLocalAddress

The old code says "The method here is to connect a UDP socket to
anyone (here to localhost)", but connecting to `localhost` doesn't
work because the connection would go via the loopback interface which
always has a local address of `127.0.0.1`.

The current code works on little-endian platforms due to a mistake in
the `createAddress` call. We pass `ntohl(INADDR_LOOPBACK)` as the IP,
but since `INADDR_LOOPBACK` is already in host order this actually
connects to `1.0.0.127`.

Fix the comments and intentionally connect to `1.1.1.1` (as a known
public IP address). This also fixes this call for big-endian
platforms.

Run Details

6443 of 12163 branches covered (52.97%)

Branch coverage included in aggregate %.

1 of 1 new or added line in 1 file covered. (100.0%)

4 existing lines in 1 file now uncovered.

12268 of 20076 relevant lines covered (61.11%)

34083.91 hits per line