Ouranosinc / xclim / 13301195306 / 2
92%
main: 92%

DEFAULT BRANCH: main
Ran
Files 72
Run time 753min
Badge
Embed ▾
README BADGES
x

If you need to use a raster PNG badge, change the '.svg' to '.png' in the link

Markdown

Textile

RDoc

HTML

Rst
coverage: 82.425% (+0.02%) from 82.407%
13301195306.2

push

github

web-flow 
Change lmoments3 behaviour with fitkwargs (#2045)

<!--Please ensure the PR fulfills the following requirements! -->
<!-- If this is your first PR, make sure to add your details to the
AUTHORS.rst! -->
### Pull Request Checklist:
- [ ] This PR addresses an already opened issue (for bug fixes /
features)
    - This PR fixes #xyz
- [x] Tests for the changes have been added (for bug fixes / features)
- [ ] (If applicable) Documentation has been added / updated (for bug
fixes / features)
- [x] CHANGELOG.rst has been updated (with summary of main changes)
- [x] Link to issue (:issue:`number`) and pull request (:pull:`number`)
has been added

### What kind of change does this PR introduce?

* Add a warning if `fitkwargs` is given with `lmoments` method
* Except if we use the `gamma` distribution is used with `floc`: This is
accepted and used to shift the distribution

### Does this PR introduce a breaking change?
No 


### Other information:

I realize that SPI/SPEI is still heavily constrained in what
distribution can be used. For now, only gamma/fisk (log-logistic) are
allowed. At some point we could revisit this. I think we reached a point
where we could be more permissive, since we ironed out many of the
potential problems in these functions. There is still potential that
problems could arise if we allow more distributions, but we might have
to accept that some problems might arise when working with these
optimization procedures, and fix them on the fly (or not, if it's just a
limitation of the method).

8775 of 10646 relevant lines covered (82.43%)

0.82 hits per line

Source Files on job run-3.10-ubuntu-latest-preliminary - 13301195306.2