1
80%
main: 80%

Ran 11 Feb 2025 05:44AM UTC

Files 57

Run time 2857min

Badge

Embed ▾

Committed 10 Feb 2025 05:02PM UTC coverage: 85.493% (+0.04%) from 85.454%

Job # 13256013660.1

Build Type

push

github

Committed by

web-flow

Commit Message

[FIXED] (2.11) Clear inflight dedupe IDs on leader change (#6486)

Reverts https://github.com/nats-io/nats-server/pull/6415 and
https://github.com/nats-io/nats-server/pull/6426. If duplication would
be deferred to be done by a replica, and that replica was down for at
least 'dupe window+5s', and it would clean up the dedupe map. A message
that was meant to be duplicate could be passed as a genuine message,
resulting in stream desync.

Instead, the dedupe map should be cleared of any staged zero-sequences.
However, that was not possible before as a new leader would not always
be fully up-to-date when it starts responding to new write requests,
which could result in duplicate messages as well.

However, relying on the 'Leader Completeness Property' implemented here:
https://github.com/nats-io/nats-server/pull/6485, we can confidently
clear the dedupe map now of any staged zero-sequences (knowing they were
not proposed). Ensuring both there's no desync, and a failed proposal
for a message would not block subsequent messages with the same dedupe
ID.

Have left the commits as separate, to ease reviewing.

Signed-off-by: Maurice van Veen <github@mauricevanveen.com>

Coverage Stats

69072 of 80793 relevant lines covered (85.49%)

901819.63 hits per line

nats-io / nats-server / 13256013660 / 1
80%
main: 80%

README BADGES
x

Markdown

Textile

RDoc

HTML

Rst

Source Files on job 13256013660.1

nats-io / nats-server / 13256013660 / 1 80% main: 80%

README BADGES x

Markdown

Textile

RDoc

HTML

Rst

Source Files on job 13256013660.1

nats-io / nats-server / 13256013660 / 1
80%
main: 80%

README BADGES
x