9 – native_assets_cli_windows
82%
main: 82%

Ran 21 Jan 2025 02:24PM UTC

Files 28

Run time 2s

Badge

Embed ▾

Committed 21 Jan 2025 02:13PM UTC coverage: 78.278%. First build

Subproject # native_assets_cli_windows – 12888806106.9

Build Type

push

github

Committed by

web-flow

Commit Message

[native_assets_cli] Introduce `CCompilerConfig.windows` (#1913)

Closes: https://github.com/dart-lang/native/issues/1606

This PR moves `cCompilerConfig.envScript` to `cCompilerConfig.windows.developerCommandPrompt.script`.

Notable changes:

* The `DeveloperCommandPrompt` is optional, but if it's set, both the script and arguments must be set. Since clang on Windows detects the MSVC installations, the `developerCommandPrompt` itself is optional for the case where clang is passed as the compiler on Windows
* The OS-specific configurations nested under `CodeConfig` have been renamed to `<OS>CodeConfig` avoid naming conflicts with `<OS>CCompilerConfig`.
* The JSON structure has been updated with the nesting.

Up for discussion:

* Naming (`developerCommandPrompt` is rather long)
* Should we expose a `Future<Map<String, String>> loadEnvironment()` on `DeveloperCommandPrompt`? It's a bit out of place because the config is rather only a view on the JSON. However, it is most likely use case.

Run Details

782 of 999 relevant lines covered (78.28%)

7.89 hits per line

dart-lang / native / 12888806106 / 9 – native_assets_cli_windows
82%
main: 82%

README BADGES
x

Markdown

Textile

RDoc

HTML

Rst

Source Files on job native_assets_cli_windows - 12888806106.9

dart-lang / native / 12888806106 / 9 – native_assets_cli_windows 82% main: 82%

README BADGES x

Markdown

Textile

RDoc

HTML

Rst

Source Files on job native_assets_cli_windows - 12888806106.9

dart-lang / native / 12888806106 / 9 – native_assets_cli_windows
82%
main: 82%

README BADGES
x