dart-lang / native / 12888806106

76%

Build Type

push

github

Committed by web-flow

Commit Message

[native_assets_cli] Introduce `CCompilerConfig.windows` (#1913)

Closes: https://github.com/dart-lang/native/issues/1606

This PR moves `cCompilerConfig.envScript` to `cCompilerConfig.windows.developerCommandPrompt.script`.

Notable changes:

* The `DeveloperCommandPrompt` is optional, but if it's set, both the script and arguments must be set. Since clang on Windows detects the MSVC installations, the `developerCommandPrompt` itself is optional for the case where clang is passed as the compiler on Windows
* The OS-specific configurations nested under `CodeConfig` have been renamed to `<OS>CodeConfig` avoid naming conflicts with `<OS>CCompilerConfig`.
* The JSON structure has been updated with the nesting.

Up for discussion:

* Naming (`developerCommandPrompt` is rather long)
* Should we expose a `Future<Map<String, String>> loadEnvironment()` on `DeveloperCommandPrompt`? It's a bit out of place because the config is rather only a view on the JSON. However, it is most likely use case.

Run Details

55 of 68 new or added lines in 5 files covered. (80.88%)

1 existing line in 1 file now uncovered.

11398 of 12992 relevant lines covered (87.73%)

38.47 hits per line