9 – native_assets_cli_macos
84%
main: 84%

Ran 07 Jan 2025 02:40PM UTC

Files 29

Run time 1s

Badge

Embed ▾

Committed 07 Jan 2025 02:32PM UTC coverage: 76.484%. First build

Subproject # native_assets_cli_macos – 12653362703.9

Build Type

push

github

Committed by

web-flow

Commit Message

[native_assets_cli] Cleanup constructors (#1867)

Addresses:

* https://github.com/dart-lang/native/pull/1824#issuecomment-2554141777

@mkustermann Do you prefer repeating the arguments to `CodeConfig` in `setupCodeConfig` leading to the following?

```dart
        ..setupCodeConfig(
          targetArchitecture: Architecture.current,
          targetOS: OS.current,
          macOSConfig: targetOS == OS.macOS
              ? MacOSConfig(targetVersion: defaultMacOSVersion)
              : null,
          linkModePreference: LinkModePreference.dynamic,
        );
```

Or rather avoiding to repeat the arguments and have the following?

```dart
        ..setupCodeConfig(CodeConfig(
          targetArchitecture: Architecture.current,
          targetOS: OS.current,
          macOSConfig: targetOS == OS.macOS
              ? MacOSConfig(targetVersion: defaultMacOSVersion)
              : null,
          linkModePreference: LinkModePreference.dynamic,
        ));
```

I've done the former now, but can easily revert that commit.

Run Details

683 of 893 relevant lines covered (76.48%)

7.82 hits per line

dart-lang / native / 12653362703 / 9 – native_assets_cli_macos
84%
main: 84%

README BADGES
x

Markdown

Textile

RDoc

HTML

Rst

Source Files on job native_assets_cli_macos - 12653362703.9

dart-lang / native / 12653362703 / 9 – native_assets_cli_macos 84% main: 84%

README BADGES x

Markdown

Textile

RDoc

HTML

Rst

Source Files on job native_assets_cli_macos - 12653362703.9

dart-lang / native / 12653362703 / 9 – native_assets_cli_macos
84%
main: 84%

README BADGES
x