dart-lang / native / 12653362703

92%

push

github

[native_assets_cli] Cleanup constructors (#1867)

Addresses:

* https://github.com/dart-lang/native/pull/1824#issuecomment-2554141777

@mkustermann Do you prefer repeating the arguments to `CodeConfig` in `setupCodeConfig` leading to the following?

```dart
        ..setupCodeConfig(
          targetArchitecture: Architecture.current,
          targetOS: OS.current,
          macOSConfig: targetOS == OS.macOS
              ? MacOSConfig(targetVersion: defaultMacOSVersion)
              : null,
          linkModePreference: LinkModePreference.dynamic,
        );
```

Or rather avoiding to repeat the arguments and have the following?

```dart
        ..setupCodeConfig(CodeConfig(
          targetArchitecture: Architecture.current,
          targetOS: OS.current,
          macOSConfig: targetOS == OS.macOS
              ? MacOSConfig(targetVersion: defaultMacOSVersion)
              : null,
          linkModePreference: LinkModePreference.dynamic,
        ));
```

I've done the former now, but can easily revert that commit.

22 of 22 new or added lines in 1 file covered. (100.0%)

12263 of 13951 relevant lines covered (87.9%)

33.86 hits per line