21
96%
3.x: 98%

Ran 05 Jan 2025 08:27PM UTC

Files 41

Run time 4s

Badge

Embed ▾

Committed 05 Jan 2025 08:25PM UTC coverage: 61.437%. Remained the same

Job # 12622703313.21

Build Type

push

github

Committed by

jrfnl

Commit Message

PHPCS: fix bug in ruleset

Hmm... this is an awkward one and may need fixing in PHPCS 4.0, but in the mean time, let's fix it here.

The base `Yoast` ruleset includes select sniffs from the `WordPressVIPMinimum` ruleset. These sniff do not apply to the PHPUnit Polyfills package.

Now, when an `<exclude name="..."/>` rule references a ruleset name to _exclude_ those sniffs, that whole standard is read and included, after which the individual sniffs from the ruleset are excluded again.

This also means that if such a ruleset _also_ includes sniffs from other standards and/or customizations (changes in severity/excludes/messaging/properties etc) to sniffs from other standards, those sniffs from other standards will still be included and the customizations still be applied.

This will often silently lead to unexpected side-effects, like in the case of the exclusion of the `WordPressVIPMinimum` ruleset, which meant that certain rules we _do_ want applied, like "no superfluous whitespace at the end of a line", got unintentionally excluded.

Fixed now by excluding the individual sniffs from the `WordPressVIPMinimum` standard which were included by the `Yoast` ruleset, instead of excluding the whole `WordPressVIPMinimum` standard.

Includes various fixes to clean up the codebase for things which are now (correctly) being flagged again.

Run Details

419 of 682 relevant lines covered (61.44%)

4.42 hits per line

Yoast / PHPUnit-Polyfills / 12622703313 / 21
96%
3.x: 98%

README BADGES
x

Markdown

Textile

RDoc

HTML

Rst

Source Files on job php-7.1-phpunit-phar-5 - 12622703313.21

Yoast / PHPUnit-Polyfills / 12622703313 / 21 96% 3.x: 98%

README BADGES x

Markdown

Textile

RDoc

HTML

Rst

Source Files on job php-7.1-phpunit-phar-5 - 12622703313.21

Yoast / PHPUnit-Polyfills / 12622703313 / 21
96%
3.x: 98%

README BADGES
x