12622703313
96%
3.x: 98%

Ran 05 Jan 2025 08:26PM UTC

Jobs 33

Files 41

Run time 1min

Badge

Embed ▾

Committed 05 Jan 2025 08:25PM UTC coverage: 96.408%. Remained the same

Build # 12622703313

Build Type

push

github

Committed by

jrfnl

Commit Message

PHPCS: fix bug in ruleset

Hmm... this is an awkward one and may need fixing in PHPCS 4.0, but in the mean time, let's fix it here.

The base `Yoast` ruleset includes select sniffs from the `WordPressVIPMinimum` ruleset. These sniff do not apply to the PHPUnit Polyfills package.

Now, when an `<exclude name="..."/>` rule references a ruleset name to _exclude_ those sniffs, that whole standard is read and included, after which the individual sniffs from the ruleset are excluded again.

This also means that if such a ruleset _also_ includes sniffs from other standards and/or customizations (changes in severity/excludes/messaging/properties etc) to sniffs from other standards, those sniffs from other standards will still be included and the customizations still be applied.

This will often silently lead to unexpected side-effects, like in the case of the exclusion of the `WordPressVIPMinimum` ruleset, which meant that certain rules we _do_ want applied, like "no superfluous whitespace at the end of a line", got unintentionally excluded.

Fixed now by excluding the individual sniffs from the `WordPressVIPMinimum` standard which were included by the `Yoast` ruleset, instead of excluding the whole `WordPressVIPMinimum` standard.

Includes various fixes to clean up the codebase for things which are now (correctly) being flagged again.

Run Details

671 of 696 relevant lines covered (96.41%)

95.53 hits per line

Jobs

ID	Job ID	Ran	Files	Coverage
1	php-7.4-phpunit-auto - 12622703313.1	05 Jan 2025 08:26PM UTC	41	9.64	GitHub Action Run
2	php-7.4-phpunit-phar-8 - 12622703313.2	05 Jan 2025 08:26PM UTC	41	35.01	GitHub Action Run
3	php-7.2-phpunit-auto - 12622703313.3	05 Jan 2025 08:26PM UTC	41	34.58	GitHub Action Run
4	php-8.4-phpunit-auto - 12622703313.4	05 Jan 2025 08:26PM UTC	41	8.57	GitHub Action Run
5	php-8.3-phpunit-9.3.0 - 12622703313.5	05 Jan 2025 08:26PM UTC	41	30.36	GitHub Action Run
6	php-7.2-phpunit-phar-6 - 12622703313.6	05 Jan 2025 08:26PM UTC	41	61.29	GitHub Action Run
7	php-5.4-phpunit-auto - 12622703313.7	05 Jan 2025 08:26PM UTC	41	68.83	GitHub Action Run
8	php-7.0-phpunit-auto - 12622703313.8	05 Jan 2025 08:27PM UTC	41	61.0	GitHub Action Run
9	php-7.1-phpunit-5.7.21 - 12622703313.9	05 Jan 2025 08:26PM UTC	41	61.44	GitHub Action Run
10	php-8.1-phpunit-auto - 12622703313.10	05 Jan 2025 08:26PM UTC	41	8.57	GitHub Action Run
11	php-7.0-phpunit-5.7.27 - 12622703313.11	05 Jan 2025 08:26PM UTC	41	61.44	GitHub Action Run
12	php-5.6-phpunit-auto - 12622703313.12	05 Jan 2025 08:26PM UTC	41	51.39	GitHub Action Run
13	php-8.1-phpunit-9.3.0 - 12622703313.13	05 Jan 2025 08:26PM UTC	41	30.54	GitHub Action Run
14	php-8.0-phpunit-auto - 12622703313.14	05 Jan 2025 08:26PM UTC	41	8.57	GitHub Action Run
15	php-8.2-phpunit-9.3.0 - 12622703313.15	05 Jan 2025 08:26PM UTC	41	30.36	GitHub Action Run
16	php-7.2-phpunit-6.3.1 - 12622703313.16	05 Jan 2025 08:26PM UTC	41	61.88	GitHub Action Run
17	php-5.6-phpunit-phar-4 - 12622703313.17	05 Jan 2025 08:26PM UTC	41	68.83	GitHub Action Run
18	php-7.4-phpunit-9.6.10 - 12622703313.18	05 Jan 2025 08:26PM UTC	41	18.75	GitHub Action Run
19	php-8.2-phpunit-auto - 12622703313.19	05 Jan 2025 08:26PM UTC	41	8.57	GitHub Action Run
20	php-7.3-phpunit-auto - 12622703313.20	05 Jan 2025 08:26PM UTC	41	9.64	GitHub Action Run
21	php-7.1-phpunit-phar-5 - 12622703313.21	05 Jan 2025 08:26PM UTC	41	61.44	GitHub Action Run
22	php-8.0-phpunit-9.3.0 - 12622703313.22	05 Jan 2025 08:26PM UTC	41	30.54	GitHub Action Run
23	php-7.3-phpunit-7.2.7 - 12622703313.23	05 Jan 2025 08:26PM UTC	41	61.44	GitHub Action Run
24	php-8.3-phpunit-auto - 12622703313.24	05 Jan 2025 08:26PM UTC	41	8.57	GitHub Action Run
25	php-7.2-phpunit-phar-8.0 - 12622703313.25	05 Jan 2025 08:26PM UTC	41	43.8	GitHub Action Run
26	php-7.3-phpunit-phar-7 - 12622703313.26	05 Jan 2025 08:26PM UTC	41	44.09	GitHub Action Run
27	php-5.5-phpunit-auto - 12622703313.27	05 Jan 2025 08:26PM UTC	41	68.83	GitHub Action Run
28	php-7.3-phpunit-phar-9.0 - 12622703313.28	05 Jan 2025 08:26PM UTC	41	34.15	GitHub Action Run
29	php-7.1-phpunit-auto - 12622703313.29	05 Jan 2025 08:26PM UTC	41	43.52	GitHub Action Run
30	php-8.4-phpunit-9.6.21 - 12622703313.30	05 Jan 2025 08:26PM UTC	41	8.57	GitHub Action Run
31	php-7.4-phpunit-8.1.6 - 12622703313.31	05 Jan 2025 08:26PM UTC	41	43.95	GitHub Action Run
32	php-5.6-phpunit-5.7.21 - 12622703313.32	05 Jan 2025 08:26PM UTC	41	51.39	GitHub Action Run
33	php-8.4-phpunit-phar-9 - 12622703313.33	05 Jan 2025 08:27PM UTC	41	8.57	GitHub Action Run

Yoast / PHPUnit-Polyfills / 12622703313
96%
3.x: 98%

README BADGES
x

Markdown

Textile

RDoc

HTML

Rst

Jobs

Source Files on build 12622703313

Yoast / PHPUnit-Polyfills / 12622703313 96% 3.x: 98%

README BADGES x

Markdown

Textile

RDoc

HTML

Rst

Jobs

Source Files on build 12622703313

Yoast / PHPUnit-Polyfills / 12622703313
96%
3.x: 98%

README BADGES
x