1
68%
ng: 85%

Ran 24 Jun 2016 06:20AM UTC

Files 333

Run time 21s

Badge

Embed ▾

Committed 24 Jun 2016 06:14AM UTC coverage: 67.203% (+0.01%) from 67.192%

Job # DJANGO_VERSION=1.4.21 TEST_DATABASE_ENGINE=mysql

Build Type

push

travis-ci

Committed by

web-flow

Commit Message

Better way of disabling publishers during handlind subscribers in Ralph3 sync (#2494)

Previously _handle_post_save attribute was assigned to the obj, which should prevent firing post_save publisher on it. Unfortunately it wasn't working perfectly - obj could be saved somewhere underneath and thus it wouldn't have this attr assigned, which caused signal (and publisher) to be fired, which may cause pub-sub cycle between Ralph2 and Ralph3.

This PR solves it by temporarly disabling post_save publisher signal during handling subscriber request.

Since signals (connectors) are not thread-safe, you may want to run runserver with --nothreading option (this would work with gunicorn out of the box, since it's using processes instead of threads).

Run Details

17003 of 25301 relevant lines covered (67.2%)

0.67 hits per line

allegro / ralph / 5879 / 1
68%
ng: 85%

README BADGES
x

Markdown

Textile

RDoc

HTML

Rst

Source Files on job 5879.1 (DJANGO_VERSION=1.4.21 TEST_DATABASE_ENGINE=mysql)

allegro / ralph / 5879 / 1 68% ng: 85%

README BADGES x

Markdown

Textile

RDoc

HTML

Rst

Source Files on job 5879.1 (DJANGO_VERSION=1.4.21 TEST_DATABASE_ENGINE=mysql)

allegro / ralph / 5879 / 1
68%
ng: 85%

README BADGES
x