allegro / ralph / 5879

68%

ng: 85%

push

travis-ci

Better way of disabling publishers during handlind subscribers in Ralph3 sync (#2494)

Previously _handle_post_save attribute was assigned to the obj, which should prevent firing post_save publisher on it. Unfortunately it wasn't working perfectly - obj could be saved somewhere underneath and thus it wouldn't have this attr assigned, which caused signal (and publisher) to be fired, which may cause pub-sub cycle between Ralph2 and Ralph3.

This PR solves it by temporarly disabling post_save publisher signal during handling subscriber request.

Since signals (connectors) are not thread-safe, you may want to run runserver with --nothreading option (this would work with gunicorn out of the box, since it's using processes instead of threads).

32 of 32 new or added lines in 4 files covered. (100.0%)

17003 of 25301 relevant lines covered (67.2%)

0.67 hits per line