2
87%
dev: 88%

Ran 17 Jun 2016 04:22PM UTC

Files 42

Run time 4s

Badge

Embed ▾

Committed 17 Jun 2016 04:18PM UTC coverage: 86.527% (+0.9%) from 85.613%

Job # TEST_TIMEOUT_SCALE=20

Build Type

push

travis-ci

Committed by

prashantv

Commit Message

Add call validation, and fix flaky call validation tests

Previously, we only validated that a timeout was set, not that a
servicename was specified when making an outbound call.

Add validation, and do it before we get a connection. This avoids
creating a connection that will not be used.

Previously, we would create a connection, do validation, and close the
connection immediately. On the inbound side, this led to a new
connection that was closed almost immediately, and so sometimes the test
would cause a:
"Failed to add connection to peer" "connection is in an invalid state"

By doing validation before we create a connection we make TestNoTimeout
less flaky, while also returning errors earlier and faster.

Run Details

3802 of 4394 relevant lines covered (86.53%)

3251.21 hits per line

uber / tchannel-go / 2072 / 2
87%
dev: 88%

README BADGES
x

Markdown

Textile

RDoc

HTML

Rst

Source Files on job 2072.2 (TEST_TIMEOUT_SCALE=20)

uber / tchannel-go / 2072 / 2 87% dev: 88%

README BADGES x

Markdown

Textile

RDoc

HTML

Rst

Source Files on job 2072.2 (TEST_TIMEOUT_SCALE=20)

uber / tchannel-go / 2072 / 2
87%
dev: 88%

README BADGES
x