• Home
  • Features
  • Pricing
  • Docs
  • Announcements
  • Sign In

uber / tchannel-go / 2072
87%
dev: 88%

Build:
Build:
LAST BUILD BRANCH: delayed_frame_alloc
DEFAULT BRANCH: dev
Ran 17 Jun 2016 04:20PM UTC
Jobs 4
Files 42
Run time 1min
Badge
Embed ▾
README BADGES
x

If you need to use a raster PNG badge, change the '.svg' to '.png' in the link

Markdown

Textile

RDoc

HTML

Rst

pending completion
2072

push

travis-ci

prashantv
Add call validation, and fix flaky call validation tests

Previously, we only validated that a timeout was set, not that a
servicename was specified when making an outbound call.

Add validation, and do it before we get a connection. This avoids
creating a connection that will not be used.

Previously, we would create a connection, do validation, and close the
connection immediately. On the inbound side, this led to a new
connection that was closed almost immediately, and so sometimes the test
would cause a:
"Failed to add connection to peer" "connection is in an invalid state"

By doing validation before we create a connection we make TestNoTimeout
less flaky, while also returning errors earlier and faster.

3845 of 4428 relevant lines covered (86.83%)

12753.66 hits per line

Jobs
ID Job ID Ran Files Coverage
1 2072.1 (TEST_TIMEOUT_SCALE=20) 17 Jun 2016 04:20PM UTC 0
86.27
Travis Job 2072.1
2 2072.2 (TEST_TIMEOUT_SCALE=20) 17 Jun 2016 04:22PM UTC 0
86.53
Travis Job 2072.2
3 2072.3 (TEST_TIMEOUT_SCALE=20) 17 Jun 2016 04:22PM UTC 0
85.59
Travis Job 2072.3
4 2072.4 (TEST_TIMEOUT_SCALE=20) 17 Jun 2016 04:22PM UTC 0
86.01
Travis Job 2072.4
Source Files on build 2072
Detailed source file information is not available for this build.
  • Back to Repo
  • Travis Build #2072
  • 061aad97 on github
  • Prev Build on validate_pre_connection (#2070)
STATUS · Troubleshooting · Open an Issue · Sales · Support · CAREERS · ENTERPRISE · START FREE · SCHEDULE DEMO
ANNOUNCEMENTS · TWITTER · TOS & SLA · Supported CI Services · What's a CI service? · Automated Testing

© 2025 Coveralls, Inc