1
93%
master: 93%

Ran 09 Jun 2016 12:24PM CUT

Files 35

Run time 1s

Badge

Embed ▾

Committed 09 Jun 2016 12:04PM CUT coverage: 90.992% (-0.1%) from 91.101%

Job # 129.1

Build Type

push

travis-ci

Committed by

sduenas

Commit Message

[api] Check identity id uniqueness in add_identity()

So far, sortinghat did not check whether the id of an identity
was already inserted in the database. It only checked if the
tuple (source, name, email, username) was stored. This might
raise some problems like in #67, when the values of an identity
are truncated because their length, so they were not found in the
database when they are compared.

With this patch this problem will not happen again because
for those cases, the UUID will be the same and a AlreadyExistError
will be raised. If for any reason the UUIDs are different,
it still have a unique constraint in the identities table that
checks if new tuples of (source, name, email, username) to be inserted
already exist in the database.

The problem with the length of the values will persist and
they will be truncated.

Run Details

2505 of 2753 relevant lines covered (90.99%)

0.91 hits per line

Source Files on job 129.1

Show entries

Search:

Coverage	File	Lines	Relevant	Covered	Missed	Hits/Line
70.33	...tricsGrimoire/sortinghat/sortinghat/db/database.py	162	91	64	27	1.0
75.29	...MetricsGrimoire/sortinghat/sortinghat/cmd/unify.py	196	85	64	21	1.0
77.12	.../MetricsGrimoire/sortinghat/sortinghat/db/model.py	349 + 310	153 + 132	118 + 99	35 + 33	1.0 - 1.0
82.5	...d/MetricsGrimoire/sortinghat/sortinghat/cmd/add.py	212 - 75	80 - 62	66 - 25	14 - 37	1.0 - 59
84.62	...etricsGrimoire/sortinghat/sortinghat/cmd/config.py	192 + 148	78 + 56	66 + 51	12 + 5	1.0
85.71	.../MetricsGrimoire/sortinghat/sortinghat/cmd/init.py	129 + 28	56 + 5	48 - 2	8 + 7	1.0 - 120
85.71	...d/MetricsGrimoire/sortinghat/sortinghat/command.py	89	42	36	6	1.0
87.5	...etricsGrimoire/sortinghat/sortinghat/cmd/export.py	271 + 263	96 + 91	84 + 79	12 + 12	1.0
87.78	.../MetricsGrimoire/sortinghat/sortinghat/cmd/load.py	525	270	237	33	1.0
89.07	...icsGrimoire/sortinghat/sortinghat/parsing/gitdm.py	378 + 374	183 + 181	163 + 161	20 + 20	1.0

Showing 1 to 10 of 35 entries

chaoss / grimoirelab-sortinghat / 129 / 1
93%
master: 93%

README BADGES
x

Markdown

Textile

RDoc

HTML

Rst

Source Files on job 129.1

chaoss / grimoirelab-sortinghat / 129 / 1 93% master: 93%

README BADGES x

Markdown

Textile

RDoc

HTML

Rst

Source Files on job 129.1

chaoss / grimoirelab-sortinghat / 129 / 1
93%
master: 93%

README BADGES
x