129
93%

Ran 09 Jun 2016 12:24PM UTC

Jobs 2

Files 35

Run time 25s

Badge

Embed ▾

pending completion

Build # 129

Build Type

push

travis-ci

Committed by

sduenas

Commit Message

[api] Check identity id uniqueness in add_identity()

So far, sortinghat did not check whether the id of an identity
was already inserted in the database. It only checked if the
tuple (source, name, email, username) was stored. This might
raise some problems like in #67, when the values of an identity
are truncated because their length, so they were not found in the
database when they are compared.

With this patch this problem will not happen again because
for those cases, the UUID will be the same and a AlreadyExistError
will be raised. If for any reason the UUIDs are different,
it still have a unique constraint in the identities table that
checks if new tuples of (source, name, email, username) to be inserted
already exist in the database.

The problem with the length of the values will persist and
they will be truncated.

Run Details

2520 of 2753 relevant lines covered (91.54%)

1.82 hits per line

Uncovered Existing Lines

Lines	Coverage	File
1	100.0	/home/travis/build/MetricsGrimoire/sortinghat/sortinghat/utils.py
3	100.0	/home/travis/build/MetricsGrimoire/sortinghat/sortinghat/parsing/eclipse.py
8	100.0	/home/travis/build/MetricsGrimoire/sortinghat/sortinghat/api.py

Jobs

ID	Job ID	Ran	Files	Coverage
1	129.1	09 Jun 2016 12:24PM UTC	0	90.99	Travis Job 129.1
2	129.2	09 Jun 2016 12:24PM UTC	0	90.74	Travis Job 129.2

Source Files on build 129

Detailed source file information is not available for this build.

chaoss / grimoirelab-sortinghat / 129
93%

README BADGES
x

Markdown

Textile

RDoc

HTML

Rst

Uncovered Existing Lines

Jobs

Source Files on build 129

chaoss / grimoirelab-sortinghat / 129 93%

README BADGES x

Markdown

Textile

RDoc

HTML

Rst

Uncovered Existing Lines

Jobs

Source Files on build 129

chaoss / grimoirelab-sortinghat / 129
93%

README BADGES
x