4
100%
master: 100%

Ran 01 Apr 2014 10:21AM UTC

Files 22

Run time 3s

Badge

Embed ▾

Committed 01 Apr 2014 10:16AM UTC coverage: 81.35% (-0.02%) from 81.366%

Job # BUILD=cmake CMAKE_OPTION="-DENABLE_GCOV=yes -DUSE_VALGRIND=no" COVERALLS=yes

Build Type

push

travis-ci

Committed by

czchen

Commit Message

Adjust chiSymbolCursor correctly in cand selection

When bPhraseChoiceRearward is enable, we need to set chiSymbolCursor to
candidate head before calling SetChoiceInfo. The value of
chiSymbolCursor is determined by oldChiSymbolCursor and candidate
length.

The original code has two problems:

1.  It has an off-by-one issue when calculate chiSymbolCursor. If
    candidate length is 1, chiSymbolCursor shall equal to
    oldChiSymbolCursor.

2.  It does not do chiSymbolCursor adjust when oldChiSymbolCursor is at
    the end of preedit buffer. When oldChiSymbolCursor is at the end of
    preedit buffer, it is not point to end of candidate. We need to
    consider it when calculate candidate head (chiSymbolCursor). This is
    also an off-by-one issue.

These two issues actual hide the problem when we open candidate at the
end of buffer because they works in different direction and becomes
off-by-zero.

Closed #140

Run Details

2844 of 3496 relevant lines covered (81.35%)

37411.75 hits per line

chewing / libchewing / 398 / 4
100%
master: 100%

README BADGES
x

Markdown

Textile

RDoc

HTML

Rst

Source Files on job 398.4 (BUILD=cmake CMAKE_OPTION="-DENABLE_GCOV=yes -DUSE_VALGRIND=no" COVERALLS=yes)

chewing / libchewing / 398 / 4 100% master: 100%

README BADGES x

Markdown

Textile

RDoc

HTML

Rst

Source Files on job 398.4 (BUILD=cmake CMAKE_OPTION="-DENABLE_GCOV=yes -DUSE_VALGRIND=no" COVERALLS=yes)

chewing / libchewing / 398 / 4
100%
master: 100%

README BADGES
x