398
100%

Ran 01 Apr 2014 10:21AM UTC

Jobs 1

Files 22

Run time 8s

Badge

Embed ▾

pending completion

Build # 398

Build Type

push

travis-ci

Committed by

czchen

Commit Message

Adjust chiSymbolCursor correctly in cand selection

When bPhraseChoiceRearward is enable, we need to set chiSymbolCursor to
candidate head before calling SetChoiceInfo. The value of
chiSymbolCursor is determined by oldChiSymbolCursor and candidate
length.

The original code has two problems:

1.  It has an off-by-one issue when calculate chiSymbolCursor. If
    candidate length is 1, chiSymbolCursor shall equal to
    oldChiSymbolCursor.

2.  It does not do chiSymbolCursor adjust when oldChiSymbolCursor is at
    the end of preedit buffer. When oldChiSymbolCursor is at the end of
    preedit buffer, it is not point to end of candidate. We need to
    consider it when calculate candidate head (chiSymbolCursor). This is
    also an off-by-one issue.

These two issues actual hide the problem when we open candidate at the
end of buffer because they works in different direction and becomes
off-by-zero.

Closed #140

Run Details

2844 of 3496 relevant lines covered (81.35%)

37411.75 hits per line

Jobs

ID	Job ID	Ran	Files	Coverage
4	398.4 (BUILD=cmake CMAKE_OPTION="-DENABLE_GCOV=yes -DUSE_VALGRIND=no" COVERALLS=yes)	01 Apr 2014 10:21AM UTC	0	81.35	Travis Job 398.4

Source Files on build 398

Detailed source file information is not available for this build.

chewing / libchewing / 398
100%

README BADGES
x

Markdown

Textile

RDoc

HTML

Rst

Jobs

Source Files on build 398

chewing / libchewing / 398 100%

README BADGES x

Markdown

Textile

RDoc

HTML

Rst

Jobs

Source Files on build 398

chewing / libchewing / 398
100%

README BADGES
x