3
97%
main: 97%

Ran 07 Sep 2024 07:29PM UTC

Files 124

Run time 2s

Badge

Embed ▾

Committed 06 Sep 2024 05:52PM UTC coverage: 78.587% (-4.6%) from 83.228%

Job # 9dd97c1e-7c61-4a5d-8488-23f75b0905af.3

Build Type

push

circleci

Committed by

mark-dce

Commit Message

[FIX] Embargo selections reset when editing ETDs

**ISSUE**
When a student or admin edits a submitted ETD, the "Content to Embargo"
setting is always reset to "Files Embargoed" regardless of what was
previously saved.

**DIAGNOSIS**
The library (and corresponding tests) that converts saved embargo
settings used a string values instead of boolean values. The source
ETD stores `files_embargoed`, `toc_embargoed`, and `abstract_embargoed`
as boolean values, bt the translation code was comparing against string
values. Examples:
```
true == 'true'
=> false

[true, true, false] == ['true', 'true', 'false']
=> false
```

**RESOLUTION**
Add test cases that demonstrate the bug and update the code to
do the comparisions using the correct data types.

Run Details

2158 of 2746 relevant lines covered (78.59%)

14.79 hits per line

curationexperts / laevigata / 9dd97c1e-7c61-4a5d-8488-23f75b0905af / 3
97%
main: 97%

README BADGES
x

Markdown

Textile

RDoc

HTML

Rst

Source Files on job 9dd97c1e-7c61-4a5d-8488-23f75b0905af.3

curationexperts / laevigata / 9dd97c1e-7c61-4a5d-8488-23f75b0905af / 3 97% main: 97%

README BADGES x

Markdown

Textile

RDoc

HTML

Rst

Source Files on job 9dd97c1e-7c61-4a5d-8488-23f75b0905af.3

curationexperts / laevigata / 9dd97c1e-7c61-4a5d-8488-23f75b0905af / 3
97%
main: 97%

README BADGES
x