1
92%
main: 92%

Ran 26 Aug 2024 06:10PM UTC

Files 934

Run time 31s

Badge

Embed ▾

Committed 26 Aug 2024 06:07PM UTC coverage: 58.589% (-0.004%) from 58.593%

Job # 10564851973.1

Build Type

push

github

Committed by

web-flow

Commit Message

fix: potential `WIN32_LEAN_AND_MEAN` redefinition (#869)

For non-cmake/autotools builds WIN32_LEAN_AND_MEAN was being defined
in ares_build.h.dist, this can cause conflicts with projects that import c-ares
and already define this.

The Node.js upgrade to c-ares v1.32.2, causes compilation failures like the following:

```
../../third_party/electron_node/deps/cares/include\ares_build.h(168,11): err
or: 'WIN32_LEAN_AND_MEAN' macro redefined [-Werror,-Wmacro-redefined]
      168 | #  define WIN32_LEAN_AND_MEAN
          |           ^
    <command line>(25,9): note: previous definition is here
       25 | #define WIN32_LEAN_AND_MEAN 1
          |         ^
    1 error generated.
    [287 processes, 49437/51449 @ 48.5/s : 1018.562s] CC obj/third_party/electro
n_node/deps/cares/cares/ares__socket.obj
    FAILED: obj/third_party/electron_node/deps/cares/cares/ares__socket.obj
```

Authored-By: Shelley Vohr (@codebytere)

Coverage Stats

22818 of 38946 relevant lines covered (58.59%)

7401.46 hits per line

c-ares / c-ares / 10564851973 / 1
92%
main: 92%

README BADGES
x

Markdown

Textile

RDoc

HTML

Rst

Source Files on job 10564851973.1

c-ares / c-ares / 10564851973 / 1 92% main: 92%

README BADGES x

Markdown

Textile

RDoc

HTML

Rst

Source Files on job 10564851973.1

c-ares / c-ares / 10564851973 / 1
92%
main: 92%

README BADGES
x