10564851973
92%

Ran 26 Aug 2024 06:10PM UTC

Jobs 1

Files 173

Run time 1min

Badge

Embed ▾

Committed 26 Aug 2024 06:07PM UTC coverage: 91.726% (-0.006%) from 91.732%

Build # 10564851973

Build Type

push

github

Committed by

web-flow

Commit Message

fix: potential `WIN32_LEAN_AND_MEAN` redefinition (#869)

For non-cmake/autotools builds WIN32_LEAN_AND_MEAN was being defined
in ares_build.h.dist, this can cause conflicts with projects that import c-ares
and already define this.

The Node.js upgrade to c-ares v1.32.2, causes compilation failures like the following:

```
../../third_party/electron_node/deps/cares/include\ares_build.h(168,11): err
or: 'WIN32_LEAN_AND_MEAN' macro redefined [-Werror,-Wmacro-redefined]
      168 | #  define WIN32_LEAN_AND_MEAN
          |           ^
    <command line>(25,9): note: previous definition is here
       25 | #define WIN32_LEAN_AND_MEAN 1
          |         ^
    1 error generated.
    [287 processes, 49437/51449 @ 48.5/s : 1018.562s] CC obj/third_party/electro
n_node/deps/cares/cares/ares__socket.obj
    FAILED: obj/third_party/electron_node/deps/cares/cares/ares__socket.obj
```

Authored-By: Shelley Vohr (@codebytere)

Run Details

20785 of 22660 relevant lines covered (91.73%)

12720.97 hits per line

Jobs

ID	Job ID	Ran	Files	Coverage
1	10564851973.1	26 Aug 2024 06:09PM UTC	0	58.59	GitHub Action Run

Source Files on build 10564851973

Detailed source file information is not available for this build.

c-ares / c-ares / 10564851973
92%

README BADGES
x

Markdown

Textile

RDoc

HTML

Rst

Jobs

Source Files on build 10564851973

c-ares / c-ares / 10564851973 92%

README BADGES x

Markdown

Textile

RDoc

HTML

Rst

Jobs

Source Files on build 10564851973

c-ares / c-ares / 10564851973
92%

README BADGES
x