1
78%
master: 79%

Ran 05 Aug 2024 12:35AM UTC

Files 260

Run time 6s

Badge

Embed ▾

Committed 05 Aug 2024 12:29AM UTC coverage: 72.426% (+0.002%) from 72.424%

Job # 10240520713.1

Build Type

push

github

Committed by

jrfnl

Commit Message

Tokenizer: apply tab replacement to heredoc/nowdoc opener

_You learn something new every day ;-)_

While probably exceedingly rare to be found in actual codebases, the PHP tokenizer apparently allows for whitespace between the `<<<` and the heredoc/nowdoc identifier. See: https://3v4l.org/NUHZd

Both spaces as well as tabs are allowed. New lines are not allowed. Comments are also not allowed. See: https://3v4l.org/7PIEK

The PHPCS `Tokenizer` did not execute tab replacement on these tokens leading to unexpected `'content'` and incorrect `'length'` values in the `File::$tokens` array, which in turn could lead to incorrect sniff results and incorrect fixes.

This commit adds the `T_START_HEREDOC`/`T_START_NOWDOC` tokens to the array of tokens for which to do tab replacement to make them more consistent with the rest of PHPCS.

Includes unit tests safeguarding this change.

Ref: https://externals.io/message/124462#124518

Run Details

17525 of 24197 relevant lines covered (72.43%)

23.95 hits per line

PHPCSStandards / PHP_CodeSniffer / 10240520713 / 1
78%
master: 79%

README BADGES
x

Markdown

Textile

RDoc

HTML

Rst

Source Files on job php-8.1-custom-ini-true - 10240520713.1

PHPCSStandards / PHP_CodeSniffer / 10240520713 / 1 78% master: 79%

README BADGES x

Markdown

Textile

RDoc

HTML

Rst

Source Files on job php-8.1-custom-ini-true - 10240520713.1

PHPCSStandards / PHP_CodeSniffer / 10240520713 / 1
78%
master: 79%

README BADGES
x