PHPCSStandards / PHP_CodeSniffer / 10240520713

78%

master: 79%

Build Type

push

github

Committed by jrfnl

Commit Message

Tokenizer: apply tab replacement to heredoc/nowdoc opener

_You learn something new every day ;-)_

While probably exceedingly rare to be found in actual codebases, the PHP tokenizer apparently allows for whitespace between the `<<<` and the heredoc/nowdoc identifier. See: https://3v4l.org/NUHZd

Both spaces as well as tabs are allowed. New lines are not allowed. Comments are also not allowed. See: https://3v4l.org/7PIEK

The PHPCS `Tokenizer` did not execute tab replacement on these tokens leading to unexpected `'content'` and incorrect `'length'` values in the `File::$tokens` array, which in turn could lead to incorrect sniff results and incorrect fixes.

This commit adds the `T_START_HEREDOC`/`T_START_NOWDOC` tokens to the array of tokens for which to do tab replacement to make them more consistent with the rest of PHPCS.

Includes unit tests safeguarding this change.

Ref: https://externals.io/message/124462#124518

Run Details

2 of 2 new or added lines in 1 file covered. (100.0%)

269 existing lines in 7 files now uncovered.

17989 of 24359 relevant lines covered (73.85%)

71.17 hits per line