5 – native_assets_cli_ubuntu
81%
main: 81%

Ran 15 Jul 2024 10:04AM UTC

Files 33

Run time 0s

Badge

Embed ▾

Committed 15 Jul 2024 09:58AM UTC coverage: 91.073% (+0.009%) from 91.064%

Subproject # native_assets_cli_ubuntu – 9937379205.5

Build Type

push

github

Committed by

web-flow

Commit Message

[native_assets_cli] Cleanup `List` from API (#1342)

Use `Iterable` over `List` in the public API:

* Immediately assigning lists into our own fields is dangerous, users might modify the list later instead of using methods on the API.
* Only giving `Iterable`s to users prevents us having to copy the list on returning a list. (Or we'd risk users modifying the internal list).

For `Map` we don't really have a different API type to signify this difference unfortunately. What we do in most of the API is:

* Have an `add(param1, param2)` method instead of using an `addAll(Map)`.
* Have a `lookupParam2(param1)` method instead of exposing a `Map`.
* But our constructors often still take maps, and we need to ensure we do a copyAll/addAll on those entries.

Run Details

908 of 997 relevant lines covered (91.07%)

4.21 hits per line

dart-lang / native / 9937379205 / 5 – native_assets_cli_ubuntu
81%
main: 81%

README BADGES
x

Markdown

Textile

RDoc

HTML

Rst

Source Files on job native_assets_cli_ubuntu - 9937379205.5

dart-lang / native / 9937379205 / 5 – native_assets_cli_ubuntu 81% main: 81%

README BADGES x

Markdown

Textile

RDoc

HTML

Rst

Source Files on job native_assets_cli_ubuntu - 9937379205.5

dart-lang / native / 9937379205 / 5 – native_assets_cli_ubuntu
81%
main: 81%

README BADGES
x