dart-lang / native / 9937379205

82%

push

github

[native_assets_cli] Cleanup `List` from API (#1342)

Use `Iterable` over `List` in the public API:

* Immediately assigning lists into our own fields is dangerous, users might modify the list later instead of using methods on the API.
* Only giving `Iterable`s to users prevents us having to copy the list on returning a list. (Or we'd risk users modifying the internal list).

For `Map` we don't really have a different API type to signify this difference unfortunately. What we do in most of the API is:

* Have an `add(param1, param2)` method instead of using an `addAll(Map)`.
* Have a `lookupParam2(param1)` method instead of exposing a `Map`.
* But our constructors often still take maps, and we need to ensure we do a copyAll/addAll on those entries.

2 of 2 new or added lines in 1 file covered. (100.0%)

9560 of 10387 relevant lines covered (92.04%)

22.72 hits per line