1
85%
master: 94%

Ran 16 May 2016 08:19AM UTC

Files 53

Run time 2s

Badge

Embed ▾

Committed 15 May 2016 09:11PM UTC coverage: 85.235% (+0.1%) from 85.132%

Job # auth_token=[secure]

Build Type

push

travis-ci

Committed by

quis

Commit Message

Handle files that can’t be interpreted as spreadsheets

There shouldn’t be a case where we see a `ValueError` on upload any
more. Our file handling should be robust enough to deal with whatever is
thrown at it.

This commit:
- adds test files with bad data (PNG files with their extensions changed to look
  like spreadsheets)
- catches whatever exceptions are raised by trying to parse these files
- returns a helpful flash message to the user

Anything else should raise a `500`, eg if the file can’t be uploaded to S3.

Run Details

1778 of 2086 relevant lines covered (85.23%)

0.85 hits per line

alphagov / notifications-admin / 3073 / 1
85%
master: 94%

README BADGES
x

Markdown

Textile

RDoc

HTML

Rst

Source Files on job 3073.1 (auth_token=[secure])

alphagov / notifications-admin / 3073 / 1 85% master: 94%

README BADGES x

Markdown

Textile

RDoc

HTML

Rst

Source Files on job 3073.1 (auth_token=[secure])

alphagov / notifications-admin / 3073 / 1
85%
master: 94%

README BADGES
x